Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test script for multiple file webseed. #397

Closed
wants to merge 111 commits into from
Closed

Added test script for multiple file webseed. #397

wants to merge 111 commits into from

Conversation

@solderzzc
Copy link
Contributor

solderzzc commented Aug 9, 2015

Added test script for multiple file webseed.
@solderzzc
Added test script for multiple file webseed.
Loading status checks…
9b0c186
@solderzzc

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

solderzzc commented Aug 9, 2015

@feross this script will not pass w/o https://github.com/feross/bittorrent-swarm/pull/24
solderzzc added 3 commits Aug 9, 2015
@solderzzc
fixed test script for multiple files torrent.
e692d34
@solderzzc
added webseed multiple files for magnet.
Loading status checks…
ecf8eb7
@solderzzc
style
Loading status checks…
041b1c9
@jakefb jakefb mentioned this pull request Sep 10, 2015
Closed
@jakefb

This comment has been minimized.

Sign in to view
Copy link
Contributor

jakefb commented Sep 16, 2015

When will this be merged? @feross
solderzzc and others added 23 commits Oct 27, 2015
@solderzzc
Switch to work repo to test multiple file download in webseed.
1c740c3
@solderzzc
Added command line hook scripts(done/exit).
5e65274 
Give a chance for the programs use webtorrent cli to run scripts when download done or exit.
@solderzzc
Fixed for CI Style check
fc459af
@solderzzc
Fixed for CI style check.
9985c83
@solderzzc
Fixed for CI style check.
7ee909f
@feross @solderzzc
command line cleanup
3a9ea8e
@feross @solderzzc
0.55.0
3eb14c6
@feross @solderzzc
build
d13db63
@feross @solderzzc
fix examples
9400482
@feross @solderzzc
fix example
57023a4
@feross @solderzzc
fix todo: use random-iterate
c0e8b3f
@feross @solderzzc
0.55.1
8f3c7c3
@feross @solderzzc
build
e4433fe
@feross @solderzzc
add torrent.numPeers
2da893d
@feross @solderzzc
add torrent.downloadSpeed/uploadSpeed
e158844
@feross @solderzzc
add client/torrent.on('download/upload')
aeb9ed4
@feross @solderzzc
cmd: use torrent.timeRemaining
afa1233
@feross @solderzzc
0.56.0
d4e5daf
@feross @solderzzc
build
90fbfd1
@gillesdemey @solderzzc
Default download destination should be current directory, fixes #390
c8e44d3
@gillesdemey @solderzzc
Use temp folder when streaming to stdout.
55f2307
@feross @solderzzc
update readme
2534f48
@feross @solderzzc
0.57.0
c5c325c
feross and others added 27 commits Sep 2, 2015
@feross @solderzzc
build
f4b04d0
@gillesdemey @solderzzc
Clone options when seeding/downloading
e3c47c5
@feross @solderzzc
standard
0bfdb75
@valeriangalliat @solderzzc
Always pass 'elem' to 'append-to' callback
f028fa3 
Looks like it was forgotten for 'img' and 'iframe'.
@feross @solderzzc
standard
fb71565
@feross @solderzzc
0.62.1
28fb2ef
@feross @solderzzc
build
8005eb8
@joseph-onsip @solderzzc
Use path.resolve in tests
510f43f 
See #429 (comment)
@joseph-onsip @solderzzc
exec/spawn cmd.js with 'node'
c3a201d 
See #429 (comment)

> This is because a windows system doesn't use the shebang so it might
> not know how to execute a js file. Spawning using node and node will
> understand how to read this.
@joseph-onsip @solderzzc
travis: cache node_modules for faster builds
b8636e2 
http://blog.travis-ci.com/2013-12-05-speed-up-your-builds-cache-your-dependencies/
@joseph-onsip @solderzzc
tests use cross-spawn-async instead of child_process.spawn
8280ee2 
This allows Windows to run the tests, as promised in
#429 (comment)

Note that there are a couple of outstanding failures on Windows:

    # client.seed: filesystem path to folder with one file, string
    not ok 8 should be equal
      ---
        operator: equal
        expected: '3a686c32404af0a66913dd5f8d2b40673f8d4490'
        actual:   'e6887b78d89d995876c7cef3476b6fb32c4c4e3d'
      ...
    not ok 9 should be equal
      ---
        operator: equal
        expected: |-
          'magnet:?xt=urn:btih:3a686c32404af0a66913dd5f8d2b40673f8d4490&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'
        actual: |-
          'magnet:?xt=urn:btih:e6887b78d89d995876c7cef3476b6fb32c4c4e3d&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'
@yousefamar @solderzzc
Accommodate Chrome/FF optional Blob arg difference
12c6a2a 
The specs say that the second Blob constructor argument is optional (http://www.w3.org/TR/FileAPI/#constructorParams), however Chrome and FF implement that differently. FF checks if the second arg is not undefined, while Chrome checks "arguments.length".

As a result, if the second argument is undefined, Chrome will throw an error (https://chromium.googlesource.com/chromium/blink/+/72fef91ac1ef679207f51def8133b336a6f6588f/LayoutTests/fast/files/blob-constructor.html#55), while FF will just ignore it.

This change makes it so that the second arg is not passed at all when it's undefined, and Chrome is happy as a result.
@feross @solderzzc
0.62.2
aa31d70
@feross @solderzzc
build
dda5c60
@joseph-onsip @solderzzc
echo "*.txt text eol=lf" >> .gitattributes
3fb0155 
This forces Windows checkouts to keep LF line endings for test files.

https://help.github.com/articles/dealing-with-line-endings/#example

resolves #429
@lucaswxp @solderzzc
Updated README.md to include events more events
b98fa9e
@feross @solderzzc
"browser" field fix
8d4bdda
@feross @solderzzc
0.62.3
d2e563e
@feross @solderzzc
build
6a7e4e5
@feross @solderzzc
build
8c54959
@solderzzc
Merge https://github.com/feross/webtorrent
54776ee
@solderzzc
Added test script for multiple file webseed.
c59a74b
@solderzzc
fixed test script for multiple files torrent.
3326ca3
@solderzzc
added webseed multiple files for magnet.
5ea51ec
@solderzzc
style
c331a4b
@solderzzc
Switch to work repo to test multiple file download in webseed.
463780d
@solderzzc
Merge branch 'add-test-script-for-multiple-file-webseed' of https://g…
Loading status checks…
479f74e 
…ithub.com/solderzzc/webtorrent into add-test-script-for-multiple-file-webseed
@solderzzc solderzzc closed this Aug 8, 2016
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
@solderzzc @jakefb @feross @gillesdemey @LinusU @Stiveknx @valeriangalliat @joseph-onsip @yousefamar @lucaswxp
You can’t perform that action at this time.