fix todo: use random-iterate

lib/torrent.js

@@ -8,6 +8,7 @@ var EventEmitter = require('events').EventEmitter
 var inherits = require('inherits')
 var parallel = require('run-parallel')
 var parseTorrent = require('parse-torrent')
+var randomIterate = require('random-iterate')
 var reemit = require('re-emitter')
 var Swarm = require('bittorrent-swarm')
 var uniq = require('uniq')
@@ -760,7 +761,11 @@ Torrent.prototype._update = function () {
   if (self.destroyed) return
 
   // update wires in random order for better request distribution
-  randomizedForEach(self.swarm.wires, self._updateWire.bind(self))
+  var ite = randomIterate(self.swarm.wires)
+  var wire
+  while ((wire = ite())) {
+    self._updateWire(wire)
+  }
 }
 
 /**
@@ -1128,23 +1133,3 @@ function getPipelineLength (wire, duration) {
 function randomInt (high) {
   return Math.random() * high | 0
 }
-
-/**
- * TODO: use random-iterate module for this
- * Iterates through the given array in a random order, calling the given
- * callback for each element.
- */
-function randomizedForEach (array, cb) {
-  var indices = array.map(function (value, index) { return index })
-
-  for (var i = indices.length - 1; i > 0; --i) {
-    var j = randomInt(i + 1)
-    var tmp = indices[i]
-    indices[i] = indices[j]
-    indices[j] = tmp
-  }
-
-  indices.forEach(function (index) {
-    cb(array[index], index, array)
-  })
-}

package.json

@@ -47,6 +47,7 @@
     "pretty-bytes": "^2.0.1",
     "pump": "^1.0.0",
     "random-access-file": "^0.3.1",
+    "random-iterate": "^1.0.1",
     "range-parser": "^1.0.2",
     "re-emitter": "^1.0.0",
     "rimraf": "^2.2.5",