Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upClone options when seeding / downloading #418
Merged
Conversation
valeriangalliat
added a commit
that referenced
this pull request
Oct 2, 2015
Clone options when seeding / downloading
valeriangalliat
merged commit a0d212c
into
webtorrent:master
1 check passed
1 check passed
This comment has been minimized.
This comment has been minimized.
|
@gillesdemey Thanks for the PR! A test would be nice, but it's more important that we merge the fix. Thanks for the taking the initiative and merging this, @valeriangalliat. Released as 0.62.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
gillesdemey commentedSep 2, 2015
Fixes #416.
Confirmed working with the code sample provided — torrents no longer override each other :)
@feross Should I figure out a test before we merge this to prevent regressions in the future?