New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature proposition] Allow to render a torrent into an existing element #425
Merged
+201
−151
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
Loading status checks…
Implement 'render-to' method
* Update 'handle' (previously 'append-to') to take a 'getElem' function instead of directly a root element, allowing to custimize the element injection method, and without directly manipulating the DOM. * Reimplement 'append-to' using abstract 'handle' method. * Implement a 'render-to' method to render a torrent inside an existing element.
- Loading branch information
| @@ -0,0 +1,35 @@ | ||
| var render = require('./render') | ||
|
|
||
| module.exports = function appendTo (file, rootElem, cb) { | ||
| if (rootElem && (rootElem.nodeName === 'VIDEO' || rootElem.nodeName === 'AUDIO')) { | ||
| throw new Error( | ||
| 'Invalid video/audio node argument. Argument must be root element that ' + | ||
| 'video/audio tag will be appended to.' | ||
| ) | ||
| } | ||
|
|
||
| render(file, function (tagName) { | ||
| if (tagName === 'video' || tagName === 'audio') return createMedia(tagName) | ||
| else return createElem(tagName) | ||
| }, function (err, elem) { | ||
| if (err && elem) { | ||
| elem.remove() | ||
| } | ||
|
|
||
| cb(err, elem) | ||
| }) | ||
|
|
||
| function createMedia (tagName) { | ||
| var elem = createElem(tagName) | ||
| elem.controls = true | ||
| elem.autoplay = true // for chrome | ||
| elem.play() // for firefox | ||
|
||
| return elem | ||
| } | ||
|
|
||
| function createElem (tagName) { | ||
| var elem = document.createElement(tagName) | ||
| rootElem.appendChild(elem) | ||
| return elem | ||
| } | ||
| } | ||
| @@ -0,0 +1,17 @@ | ||
| var path = require('path') | ||
| var render = require('./render') | ||
|
|
||
| module.exports = function renderTo (file, elem, cb) { | ||
| render(file, function (tagName) { | ||
| if (elem.nodeName !== tagName.toUpperCase()) { | ||
| var extname = path.extname(file.name).toLowerCase() | ||
|
|
||
| throw new Error( | ||
| 'Cannot render "' + extname + '" inside a "' + | ||
| elem.nodeName.toLowerCase() + '" element, expected "' + tagName + '"' | ||
| ) | ||
| } | ||
|
|
||
| return elem | ||
| }, cb) | ||
| } |
ProTip!
Use n and p to navigate between commits in a pull request.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
createMedianeeds to append to the DOM too. Right now, onlycreateElemdoes.