New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always pass 'elem' to 'append-to' callback #426

Merged
merged 1 commit into from Sep 22, 2015

Conversation

2 participants
@valeriangalliat
Contributor

valeriangalliat commented Sep 10, 2015

Looks like it was forgotten for 'img' and 'iframe'.

Always pass 'elem' to 'append-to' callback
Looks like it was forgotten for 'img' and 'iframe'.

feross added a commit that referenced this pull request Sep 22, 2015

Merge pull request #426 from valeriangalliat/hotfix/append-to-callbac…
…k-elem

Always pass 'elem' to 'append-to' callback

@feross feross merged commit ebe6930 into webtorrent:master Sep 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@feross

This comment has been minimized.

Member

feross commented Sep 22, 2015

Thanks for the PR! Released as 0.62.1.

Since you've submitted a few good PRs at this point, I've added you as a GitHub collaborator. Feel free to contribute as you see fit. 👍

@valeriangalliat valeriangalliat deleted the valeriangalliat:hotfix/append-to-callback-elem branch Sep 26, 2015

@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.