Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add an 'announce' option to announce to custom trackers #427
I updated the PR comment to make it more clear, indeed the magnet URI wasn't part of the command.
That's effectively while running a custom tracker I encountered this issue and made the PR, I had to use the JS API to announce on my tracker otherwise.
Thanks for reviewing @yciabaud.
Anything needed before mergin the PR? Like docs somewhere maybe, but I don't see other options documented in the readme except for media output options?
It does overwrite the default trackers. But that's the way create-torrent works atm. If you specify any tracker, at least one, the default are overwritten. https://github.com/feross/create-torrent/blob/master/index.js#L279-L281
We should allow two ways. "announce" and "announceList", as they are already used somehow but both replace. If you use announceList, it overwrites. If you use "announce" it concats them.
What do you think?
@DiegoRBaquero, I agree it would be nice to have a way to add trackers to the default list instead of overwriting, but in this PR I just want the CLI options to reflect the JS API (so overwriting defaults in any case).
Thanks everyone for the thoughtful discussion. Sorry for taking so long to review this PR. I've been traveling.
The CLI change looks good to me, but we should be consistent and pass the
(FWIW, any collaborator should feel free to merge a PR once there's sufficient support from other collaborators and it's been at least 3 days so everyone has a chance to weigh in with their thoughts. Power to the people