Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesUpdated chrome app manifest to allow new chrome.sockets API #43
Conversation
feross
added a commit
that referenced
this pull request
Mar 25, 2014
Updated chrome app manifest to allow new chrome.sockets API
This comment has been minimized.
This comment has been minimized.
|
Thanks for the fix! |
bricewge
pushed a commit
to bricewge/webtorrent
that referenced
this pull request
May 11, 2018
Update dependencies to enable Greenkeeper🌴
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rabidaudio commentedMar 25, 2014
Other modules began using the new chrome.sockets API: #34,
however manifest for chrome app didn't allow it and wouldn't start.