Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show torrent magnetURI when seeding #439

Closed
wants to merge 3 commits into from
Closed

Conversation

@Stiveknx
Copy link
Contributor

Stiveknx commented Sep 21, 2015

From issue #404.

@whitef0x0

This comment has been minimized.

Copy link

whitef0x0 commented Dec 5, 2015

Is there any reason this wasn't merged @feross?

@feross

This comment has been minimized.

Copy link
Member

feross commented Jan 9, 2016

Yeah, sorry for not merging this earlier. This looks like it doesn't merge cleanly anymore.

The other issue with it (and it's not the PR's fault) is that it'll break the clivas package because magnet uris will almost always be longer than the terminal width and the package can't handle rendering that.

I think a better solution is to pause with the uri visible on the screen with a "Press ENTER to start seeding." message. This gives the user the chance to copy the uri before the terminal GUI takes over.

@feross feross closed this Jan 9, 2016
@lock

This comment has been minimized.

Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.