Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign up#411 Pick an available port on "listen EADDRINUSE" or "listen EACCES" #445
Conversation
yciabaud
changed the title
This comment has been minimized.
This comment has been minimized.
|
Sorry I believe I misunderstood PR process... |
This comment has been minimized.
This comment has been minimized.
|
This looks good to me, but I wanted to make sure it could be tested automatically. I've added a (failing) test on the test-issue411 branch. Could you rebase your changes on top of that branch? |
added 2 commits
Sep 27, 2015
This comment has been minimized.
This comment has been minimized.
|
Thank you @joseph-onsip, I rebased my commits on your branch and the test looks good. |
josephfrazier
added a commit
that referenced
this pull request
Nov 9, 2015
Pick an available port on "listen EADDRINUSE" or "listen EACCES"
josephfrazier
merged commit 8f7c928
into
webtorrent:master
1 check passed
1 check passed
This comment has been minimized.
This comment has been minimized.
|
Looks great, thanks again! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yciabaud commentedSep 27, 2015
Let the OS choose a port when the default or given one is used or unauthorized.
Fixes: #411