Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exec/spawn cmd.js with 'node' #450

Merged
merged 2 commits into from Oct 5, 2015
Merged

exec/spawn cmd.js with 'node' #450

merged 2 commits into from Oct 5, 2015

Conversation

@josephfrazier
Copy link
Member

josephfrazier commented Oct 4, 2015

See #429 (comment)

This is because a windows system doesn't use the shebang so it might
not know how to execute a js file. Spawning using node and node will
understand how to read this.

(includes and resolves #449)
joseph-onsip added 2 commits Oct 4, 2015
@joseph-onsip
Use path.resolve in tests
Loading status checks…
b305550 
See #429 (comment)
@joseph-onsip
exec/spawn cmd.js with 'node'
Loading status checks…
22e487f 
See #429 (comment)

> This is because a windows system doesn't use the shebang so it might
> not know how to execute a js file. Spawning using node and node will
> understand how to read this.
@feross feross mentioned this pull request Oct 5, 2015
Closed
feross added a commit that referenced this pull request Oct 5, 2015
@feross
Merge pull request #450 from joseph-onsip/exec-spawn-node
Loading status checks…
64ac10f 
exec/spawn cmd.js with 'node'
@feross feross merged commit 64ac10f into webtorrent:master Oct 5, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Oct 5, 2015

Thanks – great work!
@josephfrazier

This comment has been minimized.

Sign in to view
Copy link
Member Author

josephfrazier commented Oct 5, 2015

Sure thing! Unfortunately, I'm not certain that #429 is completely fixed, as I don't have a Windows machine to test on. Perhaps @shavyg2 could verify?
@josephfrazier josephfrazier deleted the josephfrazier:exec-spawn-node branch Oct 5, 2015
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Oct 5, 2015

Okay, let's leave #429 open until we receive confirmation that it works.

@joseph-onsip Also, I've added you as a collaborator to WebTorrent so you can contribute as you see fit. :)
@josephfrazier

This comment has been minimized.

Sign in to view
Copy link
Member Author

josephfrazier commented Oct 5, 2015

Sounds good, cheers!
@josephfrazier josephfrazier mentioned this pull request Oct 6, 2015
Closed
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Use path.resolve in tests
3 participants
@josephfrazier @feross @joseph-onsip
You can’t perform that action at this time.