Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAccommodate Chrome/FF optional Blob arg difference #453
Conversation
The specs say that the second Blob constructor argument is optional (http://www.w3.org/TR/FileAPI/#constructorParams), however Chrome and FF implement that differently. FF checks if the second arg is not undefined, while Chrome checks "arguments.length". As a result, if the second argument is undefined, Chrome will throw an error (https://chromium.googlesource.com/chromium/blink/+/72fef91ac1ef679207f51def8133b336a6f6588f/LayoutTests/fast/files/blob-constructor.html#55), while FF will just ignore it. This change makes it so that the second arg is not passed at all when it's undefined, and Chrome is happy as a result.
feross
added a commit
that referenced
this pull request
Oct 5, 2015
Accommodate Chrome/FF optional Blob arg difference
This comment has been minimized.
This comment has been minimized.
|
@Paraknight Thanks for the PR! This is released as 0.62.2. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
yousefamar commentedOct 5, 2015
The specs say that the second Blob constructor argument is optional, however Chrome and FF implement that differently. FF checks if the second arg is not
undefined, while Chrome checksarguments.length.As a result, if the second argument is
undefined, Chrome will throw an error, while FF will just ignore it.This change makes it so that the second arg is not passed at all when it's undefined, and Chrome is happy as a result.