Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate Chrome/FF optional Blob arg difference #453

Merged
merged 1 commit into from Oct 5, 2015
Merged

Accommodate Chrome/FF optional Blob arg difference #453

merged 1 commit into from Oct 5, 2015
+1 −1
Commits on Oct 5, 2015

  1. Accommodate Chrome/FF optional Blob arg difference

    @yousefamar
    yousefamar committed Oct 5, 2015
    Loading status checks…
     
    The specs say that the second Blob constructor argument is optional (http://www.w3.org/TR/FileAPI/#constructorParams), however Chrome and FF implement that differently. FF checks if the second arg is not undefined, while Chrome checks "arguments.length".

As a result, if the second argument is undefined, Chrome will throw an error (https://chromium.googlesource.com/chromium/blink/+/72fef91ac1ef679207f51def8133b336a6f6588f/LayoutTests/fast/files/blob-constructor.html#55), while FF will just ignore it.

This change makes it so that the second arg is not passed at all when it's undefined, and Chrome is happy as a result.
    54d26e9
You can’t perform that action at this time.