Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate Chrome/FF optional Blob arg difference #453

Merged
merged 1 commit into from Oct 5, 2015
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Accommodate Chrome/FF optional Blob arg difference

The specs say that the second Blob constructor argument is optional (http://www.w3.org/TR/FileAPI/#constructorParams), however Chrome and FF implement that differently. FF checks if the second arg is not undefined, while Chrome checks "arguments.length".

As a result, if the second argument is undefined, Chrome will throw an error (https://chromium.googlesource.com/chromium/blink/+/72fef91ac1ef679207f51def8133b336a6f6588f/LayoutTests/fast/files/blob-constructor.html#55), while FF will just ignore it.

This change makes it so that the second arg is not passed at all when it's undefined, and Chrome is happy as a result.
  • Loading branch information
yousefamar committed Oct 5, 2015
commit 54d26e968cb4eb0ddbc6b1782ca7c3674f78f53b
@@ -114,7 +114,7 @@ File.prototype.getBlobURL = function (cb) {
if (err) return cb(err)
var ext = path.extname(self.name).toLowerCase()
var type = mime[ext]
var blob = new window.Blob([ buffer ], type && { type: type })
var blob = type ? new window.Blob([ buffer ], { type: type }) : new window.Blob([ buffer ])
var url = window.URL.createObjectURL(blob)
cb(null, url)
})
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.