Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uptests use cross-spawn-async instead of child_process.spawn #455
+7
−4
Conversation
This allows Windows to run the tests, as promised in #429 (comment) Note that there are a couple of outstanding failures on Windows: # client.seed: filesystem path to folder with one file, string not ok 8 should be equal --- operator: equal expected: '3a686c32404af0a66913dd5f8d2b40673f8d4490' actual: 'e6887b78d89d995876c7cef3476b6fb32c4c4e3d' ... not ok 9 should be equal --- operator: equal expected: |- 'magnet:?xt=urn:btih:3a686c32404af0a66913dd5f8d2b40673f8d4490&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80' actual: |- 'magnet:?xt=urn:btih:e6887b78d89d995876c7cef3476b6fb32c4c4e3d&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'
This comment has been minimized.
This comment has been minimized.
Hmm, this appears to have been due to a bad |
This forces Windows checkouts to keep LF line endings for test files. https://help.github.com/articles/dealing-with-line-endings/#example resolves #429
josephfrazier
pushed a commit
that referenced
this pull request
Oct 8, 2015
tests use cross-spawn-async instead of child_process.spawn
b8f8eaa
into
webtorrent:master
1 check passed
1 check passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
josephfrazier commentedOct 7, 2015
This allows Windows to run the tests, as promised in
#429 (comment)
Note that there are a couple of outstanding failures on Windows: