Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests use cross-spawn-async instead of child_process.spawn #455

Merged
merged 2 commits into from Oct 8, 2015

Conversation

@josephfrazier
Copy link
Member

josephfrazier commented Oct 7, 2015

This allows Windows to run the tests, as promised in
#429 (comment)

Note that there are a couple of outstanding failures on Windows:

# client.seed: filesystem path to folder with one file, string
not ok 8 should be equal
  ---
    operator: equal
    expected: '3a686c32404af0a66913dd5f8d2b40673f8d4490'
    actual:   'e6887b78d89d995876c7cef3476b6fb32c4c4e3d'
  ...
not ok 9 should be equal
  ---
    operator: equal
    expected: |-
      'magnet:?xt=urn:btih:3a686c32404af0a66913dd5f8d2b40673f8d4490&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'
    actual: |-
      'magnet:?xt=urn:btih:e6887b78d89d995876c7cef3476b6fb32c4c4e3d&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'
This allows Windows to run the tests, as promised in
#429 (comment)

Note that there are a couple of outstanding failures on Windows:

    # client.seed: filesystem path to folder with one file, string
    not ok 8 should be equal
      ---
        operator: equal
        expected: '3a686c32404af0a66913dd5f8d2b40673f8d4490'
        actual:   'e6887b78d89d995876c7cef3476b6fb32c4c4e3d'
      ...
    not ok 9 should be equal
      ---
        operator: equal
        expected: |-
          'magnet:?xt=urn:btih:3a686c32404af0a66913dd5f8d2b40673f8d4490&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'
        actual: |-
          'magnet:?xt=urn:btih:e6887b78d89d995876c7cef3476b6fb32c4c4e3d&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'
@josephfrazier

This comment has been minimized.

Copy link
Member Author

josephfrazier commented Oct 7, 2015

Note that there are a couple of outstanding failures on Windows:

Hmm, this appears to have been due to a bad core.autocrlf setting I had in the VM. core.autocrlf was set to true, so ./test/content/folder/file.txt had an extra CR character in it, causing the infoHash to differ. Running git config core.autocrlf input and refreshing file.txt allowed the tests to pass. See here for more info: https://help.github.com/articles/dealing-with-line-endings/#platform-linux

This forces Windows checkouts to keep LF line endings for test files.

https://help.github.com/articles/dealing-with-line-endings/#example

resolves #429
@josephfrazier josephfrazier force-pushed the josephfrazier:cross-spawn branch from 9c5a53d to 3f259a3 Oct 8, 2015
josephfrazier pushed a commit that referenced this pull request Oct 8, 2015
tests use cross-spawn-async instead of child_process.spawn
@josephfrazier josephfrazier merged commit b8f8eaa into webtorrent:master Oct 8, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@josephfrazier josephfrazier deleted the josephfrazier:cross-spawn branch Oct 8, 2015
@lock lock bot locked as resolved and limited conversation to collaborators May 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.