New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests use cross-spawn-async instead of child_process.spawn #455

Merged

josephfrazier merged 2 commits into webtorrent:master from josephfrazier:cross-spawn

Oct 8, 2015

+7 −4

Commits on Oct 7, 2015

tests use cross-spawn-async instead of child_process.spawn

joseph-onsip committed Oct 5, 2015

This allows Windows to run the tests, as promised in
#429 (comment)

Note that there are a couple of outstanding failures on Windows:

    # client.seed: filesystem path to folder with one file, string
    not ok 8 should be equal
      ---
        operator: equal
        expected: '3a686c32404af0a66913dd5f8d2b40673f8d4490'
        actual:   'e6887b78d89d995876c7cef3476b6fb32c4c4e3d'
      ...
    not ok 9 should be equal
      ---
        operator: equal
        expected: |-
          'magnet:?xt=urn:btih:3a686c32404af0a66913dd5f8d2b40673f8d4490&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'
        actual: |-
          'magnet:?xt=urn:btih:e6887b78d89d995876c7cef3476b6fb32c4c4e3d&dn=folder&tr=udp%3A%2F%2Ftracker.webtorrent.io%3A80'

80d615b

Commits on Oct 8, 2015

echo "*.txt text eol=lf" >> .gitattributes

joseph-onsip committed Oct 7, 2015

This forces Windows checkouts to keep LF line endings for test files.

https://help.github.com/articles/dealing-with-line-endings/#example

resolves #429

3f259a3

webtorrent / webtorrent

Sponsor webtorrent/webtorrent

tests use cross-spawn-async instead of child_process.spawn #455

tests use cross-spawn-async instead of child_process.spawn #455