Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clone.sh should use bash due to bashisms #485

Merged
merged 1 commit into from Nov 21, 2015
Merged

Conversation

@ivucica
Copy link
Contributor

ivucica commented Nov 19, 2015

Bashisms pushd/popd don't work so well if /bin/sh is dash, as is the case on a Debian machine.

Bashisms pushd/popd don't work so well if /bin/sh is dash, as is the case on a Debian machine.
feross added a commit that referenced this pull request Nov 21, 2015
clone.sh should use bash due to bashisms
@feross feross merged commit 5907231 into webtorrent:master Nov 21, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@feross

This comment has been minimized.

Copy link
Member

feross commented Nov 21, 2015

Thanks for the fix!

@yurivict

This comment has been minimized.

Copy link

yurivict commented on 12777c7 Nov 21, 2015

This is linux-only:

#!/bin/bash

It should be:

#!/usr/bin/env bash

This comment has been minimized.

Copy link
Contributor Author

ivucica replied Nov 22, 2015

I've seen that for Python, but never for bash.

If your bash is not in /bin, perhaps you need for fix your UNIX? Plenty of hashbangs will expect it there.

But – obviously I scratched just my itch, and you're (of course) welcome to treat yours :-)

This comment has been minimized.

Copy link
Member

feross replied Nov 22, 2015

I'm not really a pro on bash, but this stackoverflow question illuminated the issue for me: https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash

This comment has been minimized.

Copy link

yurivict replied Nov 24, 2015

It is always better to use #!/usr/bin/env regardless of an interpreter. On BSD for ex. bash is /usr/local/bin/bash.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.