Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upclone.sh should use bash due to bashisms #485
Merged
+1
−1
Conversation
Bashisms pushd/popd don't work so well if /bin/sh is dash, as is the case on a Debian machine.
feross
added a commit
that referenced
this pull request
Nov 21, 2015
clone.sh should use bash due to bashisms
This comment has been minimized.
This comment has been minimized.
|
Thanks for the fix! |
This comment has been minimized.
This comment has been minimized.
yurivict
commented on 12777c7
Nov 21, 2015
|
This is linux-only:
It should be:
|
This comment has been minimized.
This comment has been minimized.
|
I've seen that for Python, but never for bash. If your But – obviously I scratched just my itch, and you're (of course) welcome to treat yours :-) |
This comment has been minimized.
This comment has been minimized.
|
I'm not really a pro on bash, but this stackoverflow question illuminated the issue for me: https://stackoverflow.com/questions/21612980/why-is-usr-bin-env-bash-superior-to-bin-bash |
This comment has been minimized.
This comment has been minimized.
yurivict
replied
Nov 24, 2015
|
It is always better to use #!/usr/bin/env regardless of an interpreter. On BSD for ex. bash is /usr/local/bin/bash. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
ivucica commentedNov 19, 2015
Bashisms pushd/popd don't work so well if /bin/sh is dash, as is the case on a Debian machine.