Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesrefactored travis configuration #494
Conversation
This comment has been minimized.
This comment has been minimized.
|
"caching is removed as it might have problems when we change the dependency tree.", I doubt this is a problem https://blog.travis-ci.com/2013-12-05-speed-up-your-builds-cache-your-dependencies/ |
This comment has been minimized.
This comment has been minimized.
|
Well the problem is say we upgrade a version of a dependency and since we are caching we will have both the libraries and may have problems when importing them as well when there is a peer dependency breaks a version of another library with a previous build. |
This comment has been minimized.
This comment has been minimized.
I'm not sure how travis caching work, but since they specifically put it as an example in that article up there, caching is probably smarter than that. I bet if you change the dependencies then the node_modules dir is deleted. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
and how about adding |
This comment has been minimized.
This comment has been minimized.
Not quite, see https://docs.travis-ci.com/user/workers/container-based-infrastructure/#Routing-your-build-to-container-based-infrastructure
I think there are only problems if
Shouldn't |
This comment has been minimized.
This comment has been minimized.
I was referring to
It is but this will use the major version with the latest update |
This comment has been minimized.
This comment has been minimized.
That link points out that
Oh, I see now. I had assumed in #483 that since 4.2 was an LTS release, there would be no further 4.x.0 releases, but that's not necessarily the case, according to item 7 of https://github.com/nodejs/LTS/blob/d576207e6aff6f10006a47c7f7cfd02906352b10/README.md#lts-plan |
This comment has been minimized.
This comment has been minimized.
|
Hey guys, Thanks for all the discussion about how to make the travis configuration better. Here's what I suggest:
Since 1 and 2 are taken care of by other PRs I've sent, I'm going to close this issue now. Thanks again for looking into this, @udnisap, @rom1504, and @josephfrazier. |
It’s causing the tests to fail because there’s an old version of create-torrent being used.
udnisap commentedNov 27, 2015
sudo is removed as it is the default configuration.
added v4 and v5 for building environments
caching is removed as it might have problems when we change the dependency tree.