Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Using Control-C should not print "Unexpected error" message (Fix #497) #498

Merged
merged 1 commit into from Dec 2, 2015

Conversation

@feross
Copy link
Member

feross commented Dec 1, 2015

Terminating a script with Control-C returns exit code 130 in new versions of node.

…497)

Terminating a script with Control-C returns exit code 130 in new
versions of node.
@feross

This comment has been minimized.

Copy link
Member Author

feross commented Dec 2, 2015

I'm going to start sending PRs for most of my changes from now on. That way, there's more visibility into what's changing and other collaborators have a chance to give feedback.

This is a trivial change, but could someone give me a 👍? @DiegoRBaquero @lucaswxp @gillesdemey @bobrenjc93 @ivantodorovich @mafintosh

@gillesdemey

This comment has been minimized.

Copy link
Contributor

gillesdemey commented Dec 2, 2015

LGTM!

feross added a commit that referenced this pull request Dec 2, 2015
cli: Using Control-C should not print "Unexpected error" message (Fix #497)
@feross feross merged commit 0f31614 into master Dec 2, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@feross

This comment has been minimized.

Copy link
Member Author

feross commented Dec 2, 2015

Thanks - merged.

@feross

This comment has been minimized.

Copy link
Member Author

feross commented Dec 2, 2015

Released as 0.63.0.

@feross feross deleted the fix-control-c branch Dec 18, 2015
@lock

This comment has been minimized.

Copy link

lock bot commented May 5, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.