Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update npm dependencies #500

Merged
merged 4 commits into from Dec 2, 2015
Merged

Update npm dependencies #500

merged 4 commits into from Dec 2, 2015

Conversation

@feross
Copy link
Member

feross commented Dec 2, 2015

No description provided.

feross added 4 commits Dec 2, 2015
@feross
executable@2
2c3f59d
@feross
bittorrent-dht@4
388dd3f
@feross
fix test for create-torrent change
Loading status checks…
e0db3e8
@feross
remove npm cache
Loading status checks…
08ae55c 
It’s causing the tests to fail because there’s an old version of
create-torrent being used.
@feross feross mentioned this pull request Dec 2, 2015
Closed
@gillesdemey

This comment has been minimized.

Sign in to view
Copy link
Contributor

gillesdemey commented Dec 2, 2015

👍 seems like this is also required for #501 to be green on Travis.
feross added a commit that referenced this pull request Dec 2, 2015
@feross
Merge pull request #500 from feross/update-deps
Loading status checks…
e68ddb5 
Update npm dependencies
@feross feross merged commit e68ddb5 into master Dec 2, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@feross

This comment has been minimized.

Sign in to view
Copy link
Member Author

feross commented Dec 2, 2015

thanks @gillesdemey - merged.
@josephfrazier

This comment has been minimized.

Sign in to view
Copy link
Member

josephfrazier commented on 08ae55c Dec 2, 2015

EDIT: this was resolved here: #602 (comment)

(Just saw the note at #494 (comment))

Out of curiousity, shouldn't package.json have been updated in e0db3e8 to reflect the fact that a newer create-torrent is required for the tests to pass? I was thinking that if someone had webtorrent@0.62.3 installed with the create-torrent dependency at 3.15.1, then they updated to webtorrent@0.63.0, that create-torrent might remain at 3.15.1, but this doesn't actually seem to be the case for me. Nevertheless, it feels a little weird to have a (technically) invalid version range in package.json, since it could theoretically resolve to an incompatible version of create-torrent...
@feross feross deleted the update-deps branch Dec 18, 2015
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented May 5, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@feross @gillesdemey @josephfrazier
You can’t perform that action at this time.