Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README (Fix #495) #506

Merged
merged 1 commit into from Dec 2, 2015
Merged

Update README (Fix #495) #506

merged 1 commit into from Dec 2, 2015

Conversation

@DiegoRBaquero
Copy link
Member

DiegoRBaquero commented Dec 2, 2015

The path to file/folder only works in Node.js

The path to file/folder only works in Node.js
@feross

This comment has been minimized.

Copy link
Member

feross commented Dec 2, 2015

Thanks – can you also send a PR to webtorrent-www? The docs are here: https://github.com/feross/webtorrent-www/blob/master/server/views/docs.jade

I'll make an issue to unify these into one file so we don't need to keep them manually in sync.

@feross

This comment has been minimized.

Copy link
Member

feross commented Dec 2, 2015

Test failure is due to create-torrent changes. We should change the test to not assume certain trackers will be in the magnet uri.

feross added a commit that referenced this pull request Dec 2, 2015
Update README (Fix #495)
@feross feross merged commit 0619d4d into master Dec 2, 2015
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@DiegoRBaquero DiegoRBaquero deleted the DiegoRBaquero-patch-1 branch Dec 2, 2015
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.