Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upStandardize variable names (Fix #374) #510
Merged
Conversation
feross
added a commit
that referenced
this pull request
Dec 4, 2015
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 5, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedDec 3, 2015
All of @imsnif's PRs have been merged in preparation of fixing #374.
This PR finishes the job. From now on, properties that are named
infoHash,peerId, andnodeIdwill always be hex strings. To get buffers, useinfoHashBuffer,peerIdBuffer, andnodeIdBuffer.We will maintain this consistency across all the WebTorrent packages from now on.