Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize pieces on constructor #520

Merged
merged 2 commits into from Dec 9, 2015
Merged

Initialize pieces on constructor #520

merged 2 commits into from Dec 9, 2015

Conversation

@DiegoRBaquero
Copy link
Member

DiegoRBaquero commented Dec 9, 2015

Many prototype functions and properties use it and if it hasn't been initialized it will throw error as it's undefined.

Many prototype functions and properties use it and if it hasn't been initialized it will throw error as it's undefined.
Remove space to match standard
DiegoRBaquero added a commit that referenced this pull request Dec 9, 2015
Initialize pieces on torrent's constructor
@DiegoRBaquero DiegoRBaquero merged commit b302418 into master Dec 9, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@DiegoRBaquero DiegoRBaquero deleted the DiegoRBaquero-patch-1 branch Dec 9, 2015
@feross

This comment has been minimized.

Copy link
Member

feross commented Dec 17, 2015

Good catch. Released as v0.63.4.

Thanks for taking the initiative on this, and sorry for not releasing this sooner. I'm currently on vacation and have spotty internet. I'm back on Dec 22.

Next time, please don't commit the built webtorrent.min.js or push git tags. That should be done as part of npm publish and I'm going to continue keeping the power to declare releases to myself for now, though I may add others in the future. 👍

@lock

This comment has been minimized.

Copy link

lock bot commented May 5, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.