Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove tests; misc fixes #532
Merged
Conversation
- Download link uses correct filename - List shows file paths, not just name - Add file size - Show torrent name at top, instead of generic “WebTorrent” title
- check that index page works - wait for destroy
Instead of “WebTorrent/0.63.0”, it’s now “WebTorrent/0063”.
When the user sets `{ tracker: false }` on the WebTorrent client, don’t
add trackers to the torrent by default.
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 5, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedDec 17, 2015
Large PRs that contain multiple, unrelated changes are a bad idea. Nonetheless, here is a bunch of changes that I worked on while on a plane, in one large PR.
The primary purpose of this PR was to remove redundancy and repeated code from the test files. The common torrent test files that we use (
prideandleaves) are moved into a new fixture file:test/common.jsthat all test files can now use. This is more consistent, and saves multiple requires and removes boilerplate.I also removed all trackers from the sample torrent files since most tests just removed them at the start anyway. Our test suite has to work entirely offline, so contacting the network is not allowed in tests.
Errors in the
*.destroymethods are no longer ignored, and they'll fail the tests now, too.Not all test files are ported over yet. That will come in later PRs. Feel free to help out! Feedback on this PR welcome.