Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDeselect done fix #316 #533
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
This will work most of the time (and is definitely an improvement), but it won't work if the user implicitly deselects the file by deselecting all the pieces that make up the file. torrent.deselect(0, torrent.pieces.length) |
This comment has been minimized.
This comment has been minimized.
|
Here's a different approach that doesn't have the issue I mentioned above: #544 @DiegoRBaquero What do you think? |
This comment has been minimized.
This comment has been minimized.
|
Going with PR #544 |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 5, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
DiegoRBaquero commentedDec 21, 2015
If the files are deselected then they are "done"