Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesFix torrent.done state when there are deselected files (fix #316) #544
Conversation
Closed
| } | ||
| if (!done) break | ||
| } | ||
| if (!self.done && done) { |
This comment has been minimized.
This comment has been minimized.
| for (var piece = selection.from; piece <= selection.to; piece++) { | ||
| if (!self.bitfield.get(piece)) { | ||
| done = false | ||
| break |
This comment has been minimized.
This comment has been minimized.
| break | ||
| } | ||
| } | ||
| if (!done) break |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks good |
feross
added a commit
that referenced
this pull request
Dec 28, 2015
This comment has been minimized.
This comment has been minimized.
|
Released as 0.65.1. |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 5, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedDec 28, 2015
Supersedes PR #533