Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upDownload larger chunks from webseeds. #545
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
I'm taking a look at this now. Super sorry for the huge delay |
| @@ -1063,6 +1063,8 @@ Torrent.prototype._request = function (wire, index, hotswap) { | |||
| var self = this | |||
| var numRequests = wire.requests.length | |||
|
|
|||
| var webPeer = wire.remotePort === 80 || wire.remotePort === 443 | |||
This comment has been minimized.
This comment has been minimized.
feross
Mar 1, 2016
Member
Normal peers can listen on port 80 or 443. There are no rules about what ports a client can use, so this might match a normal peer. Not a huge deal right now, but it's better to be explicit since we might add other custom code for web seeds in the future and it could cause trouble.
This comment has been minimized.
This comment has been minimized.
feross
added a commit
that referenced
this pull request
Mar 1, 2016
Download larger chunks from webseeds.
This comment has been minimized.
This comment has been minimized.
|
Excellent news! This is released as 0.81.0 |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
DiegoRBaquero commentedDec 28, 2015
This is the last part of the changes required to download larger chunks from webseeds.
1st: https://github.com/feross/bittorrent-swarm/pull/29
2nd: webtorrent/torrent-piece#1
Basically the changes done to torrent.js mean:
This should fix issue #534 :)