Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix timeRemaining issue #549
Closed
Conversation
When the swarm hasn't been created but the timeRemaining property is accessed, it causes an error.
| @@ -97,7 +97,7 @@ function Torrent (torrentId, opts) { | |||
| Object.defineProperty(Torrent.prototype, 'timeRemaining', { | |||
| get: function () { | |||
| if (this.done) return 0 | |||
| if (this.swarm.downloadSpeed() === 0) return Infinity | |||
| if (this.swarm === undefined || this.swarm.downloadSpeed() === 0) return Infinity | |||
This comment has been minimized.
This comment has been minimized.
feross
Jan 1, 2016
Member
This would also fail if swarm is null. It's better to just to do:
if (!this.swarm || this.swarm.downloadSpeed() === 0) return Infinity
This comment has been minimized.
This comment has been minimized.
|
Released as 0.67.1. |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 5, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
DiegoRBaquero commentedDec 30, 2015
When the swarm hasn't been created but the timeRemaining property is accessed, it causes an error.