Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 40 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprisesUse readable-stream to address #593 #596
Conversation
This comment has been minimized.
This comment has been minimized.
|
Can you delete your second commit with the built file? I'll do that part when I do a release. Otherwise, looks good to me! Thanks @Zanadar. |
This comment has been minimized.
This comment has been minimized.
|
@feross Done. |
This comment has been minimized.
This comment has been minimized.
|
Nice work! Thanks! |
This comment has been minimized.
This comment has been minimized.
|
@Zanadar Do you have interest in sending PRs to the other repos that webtorrent uses? You can see which ones need PRs by searching for |
This comment has been minimized.
This comment has been minimized.
|
@feross That's a great idea. I'll get cracking on that. |
This comment has been minimized.
This comment has been minimized.
|
@Zanadar awesome, thanks! Looking forward to merging those PRs from you! Let me know if you need help, or have questions! |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
zmackie commentedFeb 5, 2016
Per issue #593 this swaps in
readable-streamfor corestream