Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use readable-stream to address #593 #596

Merged
merged 1 commit into from Feb 7, 2016
Merged

Use readable-stream to address #593 #596

merged 1 commit into from Feb 7, 2016

Conversation

@zmackie
Copy link

zmackie commented Feb 5, 2016

Per issue #593 this swaps in readable-stream for core stream
Zander Mackie
Swap core stream for readble-stream
Loading status checks…
a736fbe
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Feb 5, 2016

Can you delete your second commit with the built file? I'll do that part when I do a release.

Otherwise, looks good to me! Thanks @Zanadar.
@zmackie zmackie force-pushed the zmackie:zm_use-readable-stream branch from 3332f65 to a736fbe Feb 5, 2016
@zmackie

This comment has been minimized.

Sign in to view
Copy link
Author

zmackie commented Feb 5, 2016

@feross Done.
feross added a commit that referenced this pull request Feb 7, 2016
@feross
Merge pull request #596 from Zanadar/zm_use-readable-stream
Loading status checks…
5d8f4ec 
Use readable-stream to address #593
@feross feross merged commit 5d8f4ec into webtorrent:master Feb 7, 2016
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Feb 7, 2016

Nice work! Thanks!
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Feb 7, 2016

@Zanadar Do you have interest in sending PRs to the other repos that webtorrent uses?

You can see which ones need PRs by searching for require('stream') in the webtorrent node_modules folder. 😸
@zmackie

This comment has been minimized.

Sign in to view
Copy link
Author

zmackie commented Feb 7, 2016

@feross That's a great idea. I'll get cracking on that.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Feb 7, 2016

@Zanadar awesome, thanks! Looking forward to merging those PRs from you! Let me know if you need help, or have questions!
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@zmackie @feross
You can’t perform that action at this time.