Couple of changes to cmd.js

[zcecc22]

Commits documented and signed off. Ready to discuss as needed.

[feross]

I'm curious why you need the --exit option. The auto-closing behavior seems to work fine for me. What's your use case?

[feross]

This is pretty advanced information. Why do you want to show it to all users?

[zcecc22]

Seeding the torrent when done downloading.

So far the only work around Ive found was to relaunch with seed instead of
download which is not efficient on several gb torrents (long rehash).

Is'nt it best practice to keep sharing by default?

BR,
V

On Sun, 7 Feb 2016 at 21:35, Feross Aboukhadijeh notifications@github.com
wrote:

I'm curious why you need the --exit option? The auto-closing behavior
seems to work fine for me. What's your use case?

—
Reply to this email directly or view it on GitHub
#600 (comment).

[feross]

Yeah, you make a good point. My concern is that lots of folks use the command line to fetch files and then do other things with them. Example:

webtorrent magnet_uri --stdout | some-other-program

We can make it so that --stdout implies --exit.

In the future, please send separate PRs for each change you want to make so they can be discussed and merged individually.

[feross]

I like this PR, except for the changes you made to the UI. Can you remove those? It doesn't make sense to me to hide the detailed peer info under --verbose when we're already clearing the entire terminal and taking up the whole terminal buffer.

In another PR/issue, I'm open to making a more minimalist download UI similar to the npm3 one:

And we can hide the current one behind --verbose.

Sound good?

[zcecc22]

Sounds good.

I ll open new PRs for the port and exit including the implicit for stdout.

Feel free to drop this one.

Cheers,
V
On Sun, 7 Feb 2016 at 21:51, Feross Aboukhadijeh notifications@github.com
wrote:

I like this PR, except for the changes you made to the UI. Can you remove
those? It doesn't make sense to me to hide the detailed peer info under
--verbose when we're already clearing the entire terminal and taking up
the whole terminal buffer.

In another PR/issue, I'm open to making a more minimalist download UI
similar to the npm3 one:

https://camo.githubusercontent.com/4bf12754e72cf475c5e00a864744ffeaf6c06c19/687474703a2f2f69312d6e6577732e736f667470656469612d7374617469632e636f6d2f696d616765732f6e657773322f6e706d2d332d302d626574612d69732d6f75742d616464732d70726f67726573732d626172732d746f2d7468652d7061636b6167652d696e7374616c6c6174696f6e2d73637265656e2d3438353437342d332e6a7067

And we can hide the current one behind --verbose.

Sound good?

—
Reply to this email directly or view it on GitHub
#600 (comment).

[feross]

Thanks for opening new PRs. That's really awesome of you. I'll look for those.

[lock]

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.