Add appveyor.yml for automated Windows testing

[josephfrazier]

#429 reminded me that webtorrent doesn't have any automated Windows testing. AppVeyor is a service that can provide that for us. Here's an example build: https://ci.appveyor.com/project/josephfrazier/webtorrent/build/1.0.6

Note that simply merging this isn't quite enough to get builds running. AppVeyor also needs to be configured here. I should be able to do this if/once this is merged.

[feross]

Nice, hopefully this will help us catch when there's a regression on Windows! Much appreciated @josephfrazier!

[feross]

It looks like it's all configured, if you go here: https://ci.appveyor.com/project/feross/webtorrent

Also, added a badge to the readme :)

[josephfrazier]

Sweet, thanks! There's a noticeable delay on the builds, but they're better late than never.

One thing that I thought you might be interested in is that the node_modules directory is cached for the AppVeyor builds. I had done the same for Travis builds, but that change was undone (for reasons I didn't quite agree with). Do you want to remove the caching here as well?

[feross]

@josephfrazier Just saw your comment - sorry for missing it before. I think you're generally right. We should update package.json when a newer version is required for webtorrent to work correctly. Let's try to do that going forward 👍

That said, I prefer not to cache the node_modules folder on CI since I want to catch bugs that exist in the latest published packages, i.e. what a user will experience when running npm install webtorrent for the first time.

[feross]

For example, if we fix a bug and add a test for it, but forget to update package.json to be greater than the buggy version, that's bad (since users could still have the bug), but not as bad as if npm install webtorrent gets completely broken by a bad patch version of a dependency. I care more about catching the latter. :)

[josephfrazier]

Oh, that makes sense now, given that the new user experience is prioritized. I'll update appveyor.yml accordingly. Thanks for the explanation!

[feross]

@josephfrazier Thanks for caring so much about testing and reliability! :)

[lock]

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.