Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upClarify `opts.name` default behaviour #603
Merged
Conversation
First attempt at documenting the behaviour of `create-torrent` when `opts.name` isn't defined. This could use some work.
This comment has been minimized.
This comment has been minimized.
|
This is from webtorrent/create-torrent#23 |
This comment has been minimized.
This comment has been minimized.
|
Thanks for documenting this. Ideally, we can just improve the core behavior so we don't need to warn people about anything in the readme. But this works for now! @retrohacker Thanks! |
feross
added a commit
that referenced
this pull request
Feb 9, 2016
Clarify `opts.name` default behaviour
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
retrohacker commentedFeb 9, 2016
First attempt at documenting the behaviour of
create-torrentwhenopts.nameisn't defined.This could use some work.