Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Electron to run browser tests with Travis #605

Merged
merged 6 commits into from Feb 14, 2016
Merged

Conversation

@josephfrazier
Copy link
Member

josephfrazier commented Feb 9, 2016

This makes the automated testing applied to pull requests a little more comprehensive. A couple caveats:

  • This doesn't work on AppVeyor
  • Most of the browser-specific tests are skipped

I'm hoping both of these can be resolved later, but this seems like a worthwhile change regardless. Here are example builds from my personal repo: Travis, AppVeyor

feross added a commit that referenced this pull request Feb 14, 2016
Use Electron to run browser tests with Travis
@feross feross merged commit 32e7edd into master Feb 14, 2016
4 checks passed
4 checks passed
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@feross feross deleted the npm-test-browser-headless branch Feb 14, 2016
@feross

This comment has been minimized.

Copy link
Member

feross commented Feb 14, 2016

Nice work! I see a one way we can improve this further:

  • Run sauce tests locally. With this PR, these are only run when certain environment variables are set, but locally most people their credentials in .zuulrc. Locally can we just run all 3: node, electron, and sauce labs?
@josephfrazier

This comment has been minimized.

Copy link
Member Author

josephfrazier commented Feb 15, 2016

Great idea! I'll open a PR for that.

josephfrazier added a commit to josephfrazier/webtorrent that referenced this pull request Feb 15, 2016
josephfrazier added a commit to josephfrazier/webtorrent that referenced this pull request Feb 15, 2016
feross pushed a commit to webtorrent/webtorrent-cli that referenced this pull request Mar 11, 2016
feross pushed a commit to webtorrent/webtorrent-cli that referenced this pull request Mar 11, 2016
@lock

This comment has been minimized.

Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.