Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUse Electron to run browser tests with Travis #605
Merged
Conversation
feross
added a commit
that referenced
this pull request
Feb 14, 2016
Use Electron to run browser tests with Travis
This comment has been minimized.
This comment has been minimized.
|
Nice work! I see a one way we can improve this further:
|
This comment has been minimized.
This comment has been minimized.
|
Great idea! I'll open a PR for that. |
josephfrazier
added a commit
to josephfrazier/webtorrent
that referenced
this pull request
Feb 15, 2016
josephfrazier
added a commit
to josephfrazier/webtorrent
that referenced
this pull request
Feb 15, 2016
feross
pushed a commit
to webtorrent/webtorrent-cli
that referenced
this pull request
Mar 11, 2016
feross
pushed a commit
to webtorrent/webtorrent-cli
that referenced
this pull request
Mar 11, 2016
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
josephfrazier commentedFeb 9, 2016
This makes the automated testing applied to pull requests a little more comprehensive. A couple caveats:
I'm hoping both of these can be resolved later, but this seems like a worthwhile change regardless. Here are example builds from my personal repo: Travis, AppVeyor