Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache node_modules in AppVeyor tests #606

Merged
merged 1 commit into from Feb 9, 2016

Conversation

@josephfrazier
Copy link
Member

josephfrazier commented Feb 9, 2016

See the discussion at
#602 (comment)

I prefer not to cache the node_modules folder on CI since I want to
catch bugs that exist in the latest published packages, i.e. what a
user will experience when running npm install webtorrent for the first
time.

See the discussion at
#602 (comment)

> I prefer not to cache the node_modules folder on CI since I want to
> catch bugs that exist in the latest published packages, i.e.  what a
> user will experience when running npm install webtorrent for the first
> time.
josephfrazier added a commit that referenced this pull request Feb 9, 2016
Don't cache node_modules in AppVeyor tests
@josephfrazier josephfrazier merged commit cea0331 into webtorrent:master Feb 9, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@feross

This comment has been minimized.

Copy link
Member

feross commented Feb 9, 2016

LGTM 👍

@lock

This comment has been minimized.

Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.