Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upcan't download a magnet URI #607
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
@substack Thanks for the test case! I'll see what I can figure out. |
This comment has been minimized.
This comment has been minimized.
|
@substack I figured it out! Fixed in v0.74.0. Thanks for the test. It was really helpful while debugging this. Let me know if you run into any other issues! |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
substack commentedFeb 9, 2016
It's entirely possible that I'm setting up webtorrent wrong, but I can't get this simple seed+download test to work in both node, electron, and I was getting the same behavior with a similar setup for the browser. Originally I thought the problem was related to streaming, but the problem is present with files and buffers too.
If I change:
to:
then this test works. Maybe there is an issue with trackers or magnet links? I haven't made much progress on what might be causing this issue.