Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use .zuulrc credentials for Sauce Labs tests #619

Merged
merged 6 commits into from Feb 19, 2016
Merged

Use .zuulrc credentials for Sauce Labs tests #619

merged 6 commits into from Feb 19, 2016

Conversation

@josephfrazier
Copy link
Member

josephfrazier commented Feb 15, 2016

As discussed in #605 (comment)
@josephfrazier
.gitignore .zuulrc
c15e35e 
People probably just use ~/.zuulrc instead, but let's ignore it here
anyway to be on the safe side.
@josephfrazier
Use .zuulrc credentials for Sauce Labs tests
7e61cfd 
See #605 (comment)
@josephfrazier
Always run Electron tests during `npm test`
973dbe5 
See #605 (comment)
@josephfrazier
bin/test.js: move process.exit logic into npmRun helper
Loading status checks…
a59b4db 
This helps reduce nesting.
@josephfrazier

This comment has been minimized.

Sign in to view
Copy link
Member Author

josephfrazier commented Feb 15, 2016

I pushed the use-zuulrc-credentials branch into this repo as well, so we can see the build that has access to the Sauce Labs credentials in .travis.yml: https://travis-ci.org/feross/webtorrent/builds/109267142
@josephfrazier
bin/test.js: npmRun() exits process if no callback
Loading status checks…
89b6d15
@josephfrazier
Merge branch 'master' into use-zuulrc-credentials
Loading status checks…
24b4b6f
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Feb 19, 2016

It's too bad that the specific way that zuul looks for .zuulrc had to be inlined in here, but at least the zuul tests run locally again!
feross added a commit that referenced this pull request Feb 19, 2016
@feross
Merge pull request #619 from josephfrazier/use-zuulrc-credentials
Loading status checks…
5683f0c 
Use .zuulrc credentials for Sauce Labs tests
@feross feross merged commit 5683f0c into webtorrent:master Feb 19, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
feross added a commit that referenced this pull request Feb 19, 2016
@feross
remove duplicate dep from #619
b4376a9
feross added a commit that referenced this pull request Feb 19, 2016
@feross
test: always run saucelabs test locally (#619)
Loading status checks…
54ef9db 
I think this is a simpler approach for #619. Always run the sauce labs
tests locally. If users lack the right sauce labs credentials, they’ll
get an error and hopefully set up zuul correctly before sending a PR.
@feross feross mentioned this pull request Feb 19, 2016
Merged
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented Feb 19, 2016

Attempted a simpler solution here: #626
@josephfrazier josephfrazier deleted the josephfrazier:use-zuulrc-credentials branch Oct 14, 2016
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@josephfrazier @feross
You can’t perform that action at this time.