Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign uptest: Always run saucelabs tests locally #626
Merged
Conversation
feross
changed the title
This comment has been minimized.
This comment has been minimized.
|
Tests all pass. Merging! |
feross
added a commit
that referenced
this pull request
Feb 19, 2016
test: Always run saucelabs tests locally
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedFeb 19, 2016
I think this is a simpler approach for #619. Always run the sauce labs
tests locally. If users lack the right sauce labs credentials, they’ll
get an error and hopefully set up zuul correctly before sending a PR.