Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Always run saucelabs tests locally #626

Merged
merged 2 commits into from Feb 19, 2016
Merged
Changes from 1 commit
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev

test: always run saucelabs test locally (#619)

I think this is a simpler approach for #619. Always run the sauce labs
tests locally. If users lack the right sauce labs credentials, they’ll
get an error and hopefully set up zuul correctly before sending a PR.
  • Loading branch information
feross committed Feb 19, 2016
commit 54ef9db15018d3831d3d9bc67bbcd70bbb88c1c1
@@ -1,15 +1,9 @@
#!/usr/bin/env node

var spawn = require('cross-spawn-async')
var findNearestFile = require('find-nearest-file')
var path = require('path')
var userHome = require('user-home')
var pathExists = require('path-exists')

// .zuulrc logic from https://github.com/defunctzombie/zuul/blob/a0de46a5906c84b19f655c487f7c8debe938984d/bin/zuul#L384
var zuulrcPath = findNearestFile('.zuulrc') || path.join(userHome, '.zuulrc')
var hasSauceLabEnvVars = process.env.SAUCE_USERNAME && process.env.SAUCE_ACCESS_KEY
var runSauceLabs = hasSauceLabEnvVars || pathExists.sync(zuulrcPath)
var runSauceLabs = !process.env.CI ||
(process.env.SAUCE_USERNAME && process.env.SAUCE_ACCESS_KEY)

npmRun('test-node', function () {
npmRun('test-browser-headless', function () {
@@ -83,14 +83,12 @@
"cross-spawn-async": "^2.0.0",
"electron-prebuilt": "^0.36.7",
"finalhandler": "^0.4.0",
"find-nearest-file": "^1.0.0",
"run-series": "^1.0.2",
"serve-static": "^1.9.3",
"simple-get": "^2.0.0",
"standard": "^6.0.1",
"tape": "^4.0.0",
"uglify-js": "^2.4.15",
"user-home": "^2.0.0",
"zuul": "^3.0.0"
},
"homepage": "https://webtorrent.io",
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.