Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upadding bittorrent-peerid to README #63
Conversation
This comment has been minimized.
This comment has been minimized.
|
Latest commits in this PR add support for resuming torrent downloads by adding initial piece verification. Note that this required shuffling around some of the ordering of things and now torrents emit both 'metadata' and 'ready' events. 'metadata' when the torrent's received its metadata, and 'ready' when it's fully ready to start transport (meaning the storage, swarm, and trackers have all been initialized including initial piece verification of the storage). You can now download a torrent, interrupt it partway through, start webtorrent again with the same torrent, and it'll correctly pick up where it left off! Trying to redownload a completed torrent will likewise stop after initial piece verification without any actual transferring. |
This comment has been minimized.
This comment has been minimized.
|
Note that this PR now depends on my related bittorrent-client PR https://github.com/feross/bittorrent-client/pull/20 |
This comment has been minimized.
This comment has been minimized.
feross
commented on lib/fs_storage.js in 32bac0c
Jun 3, 2014
|
single quotes |
This comment has been minimized.
This comment has been minimized.
|
Looks good! Tip (in case you don't know): If you want to submit multiple separate PRs, create a branch for each PR. When you commit straight to master, your new commits just get added into your existing PR. ;) |
transitive-bullshit commentedMay 28, 2014
@feross: this is my smallest PR yet👍