Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding bittorrent-peerid to README #63

Merged
merged 5 commits into from
Jun 3, 2014

Conversation

transitive-bullshit
Copy link
Member

@feross: this is my smallest PR yet 👍

…also includes a slight optimization to separate opening an fs file for reading vs writing
@transitive-bullshit
Copy link
Member Author

Latest commits in this PR add support for resuming torrent downloads by adding initial piece verification. Note that this required shuffling around some of the ordering of things and now torrents emit both 'metadata' and 'ready' events. 'metadata' when the torrent's received its metadata, and 'ready' when it's fully ready to start transport (meaning the storage, swarm, and trackers have all been initialized including initial piece verification of the storage).

You can now download a torrent, interrupt it partway through, start webtorrent again with the same torrent, and it'll correctly pick up where it left off! Trying to redownload a completed torrent will likewise stop after initial piece verification without any actual transferring.

@transitive-bullshit
Copy link
Member Author

Note that this PR now depends on my related bittorrent-client PR https://github.com/feross/bittorrent-client/pull/20

@feross feross merged commit 98a2fa7 into webtorrent:master Jun 3, 2014
@feross
Copy link
Member

feross commented Jun 3, 2014

Looks good!

Tip (in case you don't know): If you want to submit multiple separate PRs, create a branch for each PR. When you commit straight to master, your new commits just get added into your existing PR. ;)

@lock lock bot locked as resolved and limited conversation to collaborators May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants