Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upremove webtorrent-cli #656
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
|
(is |
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR! This looks good, but I can't merge it now because there are conflicts. |
This comment has been minimized.
This comment has been minimized.
|
Thanks again for the excellent PR. I opened a new PR that includes your changes and without the merge conflict since I can't push to your branch. Also, I'll add you as a contributor to this repo :) |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
rom1504 commentedMar 3, 2016
would be #653
This PR is an experiment, to see what removing the cli means.
If that's what we want to do, then a webtorrent-cli package should be created out of what is deleted in that PR.
With this PR node_modules contains 615 top level directories which sums up to a 16285 files (1m56.962s install time)
Without it, it contains 638 top level directories which sums up to 20089 files (2m21.811s install time)
(these numbers are for a full installation including devDependencies and optionalDependencies)
I think I removed all the dependencies used in the cli, and only them.