Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upLimit the number of simultaneous connections per web seed #664
Conversation
README.md
Outdated
| @@ -275,7 +275,8 @@ If `opts` is specified, then the default options (shown below) will be overridde | |||
| announce: [], // Torrent trackers to use (added to list in .torrent or magnet uri) | |||
| getAnnounceOpts: function, // Custom callback to allow sending extra parameters to the tracker | |||
| path: String, // Folder to download files to (default=`/tmp/webtorrent/`) | |||
| store: Function // Custom chunk store (must follow [abstract-chunk-store](https://www.npmjs.com/package/abstract-chunk-store) API) | |||
| store: Function // Custom chunk store (must follow [abstract-chunk-store](https://www.npmjs.com/package/abstract-chunk-store) API), | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Looks good to me. This is a nice option to have so connection limits per IP don't break the whole thing. |
This comment has been minimized.
This comment has been minimized.
|
@feross is continuous-integration/appveyor/branch working? it seems is stopping all PRs to be ready to merge |
This comment has been minimized.
This comment has been minimized.
|
I'm fine with this as a temporary stop-gap. But this is gross. All this complexity should be handled for the user by the web seed implementation. |
feross
added a commit
that referenced
this pull request
Mar 11, 2016
…imit Limit the number of simultaneous connections per web seed
This comment has been minimized.
This comment has been minimized.
|
0.83.1. |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
grunjol commentedMar 9, 2016
PR #663 limits the amount of connections in case of low bandwidth web seed
But in case of per IP connection limits like
nginx's limit_conn addr
Wowza
Nimble
this prevents connection rejections (HTTP 50x) and consecuently web seed been discarded as discussed in #650