Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upBase web seed pipeline length on piece length #723
Merged
Conversation
Before this, the web seed pipeline length was based on the block size, just like it is for wire connections, which are block-based. This meant that we were massively over-estimating the number of http requests to make to the web seed servers. Now we use the piece length, since each web seed request is a piece length in size.
This comment has been minimized.
This comment has been minimized.
|
Reviewed in-person by @dcposch. |
Merged
This comment has been minimized.
This comment has been minimized.
|
0.90.2 |
This comment has been minimized.
This comment has been minimized.
|
|
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedApr 6, 2016
Before this, the web seed pipeline length was based on the block size,
just like it is for wire connections, which are block-based.
This meant that we were massively over-estimating the number of http
requests to make to the web seed servers.
Now we use the piece length, since each web seed request is a piece
length in size.