Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAPI improve #750
Merged
API improve #750
Conversation
infohash, metadata and ready note. Added uploaded
This was referenced Apr 12, 2016
docs/api.md
Outdated
| @@ -400,6 +399,21 @@ See the `bittorrent-protocol` | |||
| [extension api docs](https://github.com/feross/bittorrent-protocol#extension-api) for more | |||
| information on how to define a protocol extension. | |||
|
|
|||
| ## `torrent.on('infoHash', function () {})` | |||
|
|
|||
| Emitted when the info hash of the torrent has been determined. Can only be accessed synchronously as client.add calls onTorrent callback after 'infoHash' event has been emitted. | |||
This comment has been minimized.
This comment has been minimized.
feross
Apr 16, 2016
Member
I don't think we need the extra text. It makes it more confusing IMO. It's already clear from the fact that this is an event that it's async.
This comment has been minimized.
This comment has been minimized.
|
Documenting the |
This comment has been minimized.
This comment has been minimized.
|
@feross removed extra comments |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
DiegoRBaquero commentedApr 12, 2016
infohash, metadata and ready note. Added uploaded