BREAKING: Many fixes; all leaks fixed

[feross]

Added

• client.listening property to signal whether TCP server is listening for incoming
  connections.
• client.dhtPort property to show the actual chosen DHT port (parallel to client.torrentPort for the TCP torrent listening server)

Changed

• Merged Swarm class into Torrent object. Properties on torrent.swarm (like
  torrent.swarm.wires) now exist on torrent (e.g. torrent.wires). Deleted a ton of code!
• Deprecate: Do not use torrent.swarm anymore. Use torrent instead.
• torrent.addPeer can no longer be called before the infoHash event has been
  emitted.
• Remove torrent.on('listening') event. Use client.on('listening') instead.
• Remove support from TCPPool for listening on multiple ports. This was not used by
  WebTorrent and just added complexity. There is now a single TCPPool instance for the
  whole WebTorrent client.
• Deprecate: Do not use client.download() anymore. Use client.add() instead.
• Only pass torrent.infoHash to the Chunk Store constructor, instead of the Torrent
  instance itself, to prevent accidental memory leaks of the Torrent object by the
  store. (Open an issue if you were using other properties. They can be re-added.)
• Non-fatal errors with a single torrent will be emitted at torrent.on('error'). You
  should listen to this event. Previously, all torrent errors were also emitted on
  client.on('error') and handling torrent.on('error') was optional. The new design is
  better since now it is possible to distinguish between fatal client errors
  (client.on('error')) when the whole client becomes unusable versus recoverable errors
  where only a single torrent fails (torrent.on('error')) but the client can continue to
  be used. However, if there is no torrent.on('error') event, then the error will be
  forwarded to client.on('error'). This prevents crashing the client when the user
  only has a listener on the client, but it makes it impossible for them to determine
  a client error versus a torrent error.

Fixed

• If client.get is passed a Torrent instance, it now only returns it if it is present
  in the client.
• Errors creating a torrent with client.seed are now emitted on the returned torrent
  object instead of the client (unless there is no event listeners on
  torrent.on('error') as previously discussed). The torrent object is now also destroyed
  automatically for the user, as was probably expected.
• Do not return existing torrent object when duplicate torrent is added. Fire an
  'error' event instead.
• Memory leaks of Torrent object caused by many internal subclasses of WebTorrent,
  including RarityMap, TCPPool, WebConn, Server, File, Torrent.
• client.ratio and torrent.ratio are now calculated as uploaded / received instead
  of uploaded / downloaded.

Closes #721
Closes #712
Closes #635
Closes #317
Closes #248

[dcposch]

Might want to delete the commented out files. Or are you planning to port the tests to use torrent instead of swarm later?

[feross]

Planning to port the tests later.

[dcposch]

This is awesome.

Also when you exclude release notes and commented-out tests, you're mostly removing code.

https://twitter.com/henrikjoreteg/status/545424384954228736

[feross]

Swarm tests are disabled for now, since there's no Swarm class anymore to test. It's part of Torrent. I'll see what testing is worth keeping and what is redundant in a future PR.

[feross]

I want to get a PR ready for webtorrent-cli ready before merging this. Will release tomorrow.

[grunjol]

I think this is the PR everybody was waiting for :D.

[feross]

PR to webtorrent-cli wasn't so bad: webtorrent/webtorrent-cli#6

[lock]

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.