Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upTest Node v5 on Travis/Appveyor (v6 is stable) #774
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
|
We only need to officially support the LTS and Current versions, i.e. the versions that are linked from https://nodejs.org/en/ But we can leave the node 5 tests in for a while -- doesn't hurt. |
This comment has been minimized.
This comment has been minimized.
|
Ah, ok, I wasn't sure which platforms we're targeting here. I see that v5 will be supported for only two more months, so that might be a good time to remove the tests: https://nodejs.org/en/blog/release/v6.0.0/#what-about-node-js-v5 |
This comment has been minimized.
This comment has been minimized.
|
@josephfrazier Sounds good |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
josephfrazier commentedApr 27, 2016
No description provided.