Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'noPeers' event to torrents #775

Merged
merged 3 commits into from May 5, 2016
Merged

Add 'noPeers' event to torrents #775

merged 3 commits into from May 5, 2016

Conversation

@harperj
Copy link

harperj commented Apr 27, 2016

The 'noPeers' event is emitted after tracker or DHT announce events when there are still no peers in the swarm.
Jonathan Harper added 2 commits Apr 27, 2016
Jonathan Harper
Torrent emits 'noPeers' even when swarm is empty after announce
cd7fcb2
Jonathan Harper
Document 'noPeers' torrent event
Loading status checks…
9824899
@harperj harperj force-pushed the harperj:no-peers branch from 5f1e8f9 to 9824899 Apr 27, 2016
@harperj harperj closed this Apr 27, 2016
@harperj harperj reopened this Apr 27, 2016
Jonathan Harper
Update 'noPeers' to stop using deprecated 'torrent.swarm'
Loading status checks…
97130eb
@harperj harperj mentioned this pull request Apr 27, 2016
Closed
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented May 5, 2016

Thanks for this PR!

However before merging, I feel like we should work on making this event more useful to the user. If I listen to 'noPeers', there's no guarantee that more peers aren't about to be found from another discovery mechanism.
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented May 5, 2016

But this is much better than nothing, so let's merge it for now!
@feross feross merged commit f09c24a into webtorrent:master May 5, 2016
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@feross

This comment has been minimized.

Sign in to view
Copy link
Member

feross commented May 5, 2016

0.92.0
@harperj

This comment has been minimized.

Sign in to view
Copy link
Author

harperj commented May 5, 2016

I agree. I'll try to take a look at this again shortly.

On Thu, May 5, 2016, 6:14 AM Feross Aboukhadijeh notifications@github.com
wrote:

0.92.0

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#775 (comment)
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented May 4, 2018

This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue.
@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@harperj @feross
You can’t perform that action at this time.