Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes for PR #799 #809
Merged
Fixes for PR #799 #809
Conversation
- Support multiple &xs= params in parallel - Fail on 'error' 'warning' events
This comment has been minimized.
This comment has been minimized.
|
@Sebmaster Can you please review this PR when you get the chance? |
| // wait for torrent-discovery to find peers and ut_metadata to get the metadata. | ||
| self._onMetadata(self) | ||
| } else if (self.xs) { | ||
| self._getMetadataFromServer() |
This comment has been minimized.
This comment has been minimized.
feross
May 19, 2016
Author
Member
Moved to after listening event since it's really fast and it's when the other discovery happens. This may prevent future bugs where we expect to already be listening.
lib/torrent.js
Outdated
| return cb(null) | ||
| } | ||
| if (res.statusCode !== 200) { | ||
| self._debug('non-200 status code from xs param: %s', url) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
LGTM otherwise. |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedMay 19, 2016