Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upUse safe-buffer #821
Merged
Use safe-buffer #821
Conversation
Use the new Buffer APIs from Node v6 for added security. For example, Buffer.from() will throw if passed a number, unlike Buffer() which allocated UNINITIALIZED memory. Use the safe-buffer package for compatibility with previous versions of Node.js, including v4.x, v0.12, and v0.10. https://github.com/feross/safe-buffer
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
feross commentedMay 30, 2016
•
edited
Use the new Buffer APIs from Node v6 for added security. For example,
Buffer.from()will throw if passed a number, unlikeBuffer()whichallocated UNINITIALIZED memory in that case.
Use the
safe-bufferpackage for compatibility with previous versions ofNode.js, including v4.x, v0.12, and v0.10.
https://github.com/feross/safe-buffer