Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null check pendingConns #834

Merged
merged 1 commit into from Jun 12, 2016
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Update tcp-pool.js

Prevent arrayRemove if the pool is already destroyed. Fixes possible error `TypeError: Cannot read property 'indexOf' of null`
  • Loading branch information
DiegoRBaquero committed Jun 11, 2016
commit 4ca41659d2c1e635260e4f40716e436387b3b77c
@@ -119,7 +119,7 @@ TCPPool.prototype._onConnection = function (conn) {
function cleanupPending () {
conn.removeListener('close', cleanupPending)
wire.removeListener('handshake', onHandshake)
arrayRemove(self._pendingConns, self._pendingConns.indexOf(conn))
if(self._pendingConns) arrayRemove(self._pendingConns, self._pendingConns.indexOf(conn))
}
}

ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.