Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upBugfixes for server.close() and server.destroy() #901
Merged
Conversation
| @@ -37,6 +37,7 @@ function Server (torrent, opts) { | |||
| }) | |||
|
|
|||
| // Only call `server.close` if user has not called it already | |||
| if (!cb) cb = function () {} | |||
This comment has been minimized.
This comment has been minimized.
feross
Sep 13, 2016
Member
It's best to set all defaults at the top of the function instead of in the body.
This comment has been minimized.
This comment has been minimized.
|
LGTM -- thanks for catching this. |
This comment has been minimized.
This comment has been minimized.
|
0.96.5 |
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
May 4, 2018
|
This thread has been automatically locked because it has not had recent activity. To discuss futher, please open a new issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
dcposch commentedSep 4, 2016
•
edited
@feross @mikeal