Skip to content

/ webtorrent

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable BEP19 web seeds #911

Merged
merged 4 commits into from Sep 17, 2016
+63 −6
Merged

Option to disable BEP19 web seeds #911

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5bdc78c
Option to disable BEP19 web seeds
dcposch Sep 15, 2016
79484a5
Test option to disable web seeds
dcposch Sep 15, 2016
dc108ed
0.97.0
dcposch Sep 17, 2016
3115519
changelog
dcposch Sep 17, 2016
File filter...
Filter file types
Clear filters
Jump to…
Jump to file or symbol
Failed to load files and symbols.

Always

Just for now

Prev Next
Loading status checks…

0.97.0

  • Loading branch information
@dcposch
dcposch committed Sep 17, 2016
commit dc108ed0653c112f57dd2beb590de99aaae1878a
2 package.json
View file
Open in desktop
@@ -1,7 +1,7 @@
{
"name": "webtorrent",
"description": "Streaming torrent client",
"version": "0.96.5",
"version": "0.97.0",

This comment has been minimized.

Sign in to view
Copy link
@feross

feross Sep 17, 2016 •
edited

Member

In the future, please don't change the package.json version in a PR. That's best done at release time with the npm version command (i.e. npm version patch, npm version minor, npm version major).

This comment has been minimized.

Sign in to view
Copy link
@feross

feross Sep 17, 2016

Member

If you're curious about the exact commands I use to do a release, they are here: https://github.com/feross/prezto/blob/master/runcoms/zshrc#L31-L33

This comment has been minimized.

Sign in to view
Copy link
@feross

feross Sep 17, 2016

Member

Sorry -- I see now that you did make a separate commit for the version bump. Still, it's not good to encourage this in PRs. When random people send you a PR and increment the version, it makes it harder to merge that PR.

This comment has been minimized.

Sign in to view
Copy link
@dcposch

dcposch Sep 18, 2016

Author Contributor

I did use npm version minor

I bumped the version because I need it for the desktop app: webtorrent/webtorrent-desktop#913
"author": {
"name": "WebTorrent, LLC",
"email": "feross@webtorrent.io",
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.